-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product api #7
Open
santoshkavhar
wants to merge
127
commits into
development
Choose a base branch
from
product_api
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Product api #7
+2,493
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created. assets folder added which will contain product images. Code was successfully tested for mentioned APIs.
…n of ProductImages url field is changed to text.
…was modified, adding these changes. migrations.sql's queries are updated. Testing of all the APIs was done and it was successful for Product insertion, fetch all products, fetch single product, and delete a product.
…ize and color are added.
… removed as it is implicit in Product Filters API. Error responses have been handled more properly.Total Records Method was given error as return.
…so some changes in migrations.sql dump.
… Filters and Product's API's function call reduced by combining the count and actual product getting Function into just one function. Queries put as constants in case of Product API. Instead of using Double quotes used back tick for Queries.
…nto product_api Merging for integration.
…ield still present, its handled as well.
…, product.CategoryName no more needed to be set up.
…t structure for help in same. Changes made accordingly to Filters and Search API,so this is highly unstable version. In Response.go StatusBadRequest changed to status.
… TotalRecords field from Product structure as it is a bad practice.
…ntation. Extra variable is eliminated.
…ble on the same line.
…d helps us to fetch Products from Records. Method is used in ListProducts, FilterProduct and SearchProduct.
…osed to be part of future deployments.
…from docker and also to build locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product API has functionality of fetching all products, or fetching products by filters. Pagination is added in both these APIs, which sends the response as number of pages formed. In update Product's stock API, we are only updating the Available Quantity. There is also an API written to delete a Product by its ID.